IPB 3 Query Check

[immortalxx]

Does this query look alright?

                    $this->DB->do_update( 'forums', array( 
                                            'posts=posts+1', 
                                            'last_post' => $now, 
                                            'last_title' => $post_title, 
                                            'last_id' => $topic_id,
                                            'last_poster_id' => $starter_id, 
                                            'last_poster_name' => $starter_name ),
                                            'id='.$forum_id
                     );

 

[Zeokat]

This part is weird... since it´s between single quotes, it refers to a var named posts=posts+1 , weird... but who knows... i´m not IPB lover.

'posts=posts+1'

Perhaps it should be:

..... array( 
'posts' => $posts+1 ,
etc....

 

[immortalxx]

posts is a field name, im telling it to update the field to what ever it was plus 1 not sure if thats how you do it with IPB

 

[immortalxx]

anyone know how to get the last inserted id?

 

[Buddah]

$this->DB->getInsertId();

Will do just that.

 

[Buddah]

Also, for your query,

                    $this->DB->do_update( 'forums', array( 
                                            'posts' => 'posts+1', 
                                            'last_post' => $now, 
                                            'last_title' => $post_title, 
                                            'last_id' => $topic_id,
                                            'last_poster_id' => $starter_id, 
                                            'last_poster_name' => $starter_name ),
                                            'id='.$forum_id
                     );

** If you're using IP.Board 3, do_update() is replaced by update().

 

[immortalxx]

that 'posts' => 'posts+1' doesnt work, it tried to install that as a string, i need it to take the field and add 1 to it

 

[Buddah]

That's odd. Try using the plus: logic operator.

                    $this->DB->update( 'forums', array( 
                                            'posts' => 'plus:1', 
                                            'last_post' => $now, 
                                            'last_title' => $post_title, 
                                            'last_id' => $topic_id,
                                            'last_poster_id' => $starter_id, 
                                            'last_poster_name' => $starter_name ),
                                            'id='.$forum_id
                     );

 

[immortalxx]

not sure why that would do anyhting differently it most likely turns the second var into an escaped string so no matter what it is it will become 'plus:1'

 

[Buddah]

You need to force the data type to int...

                    $this->DB->force_data_type['posts'] = 'int';

                    $this->DB->update( 'forums', array( 
                                            'posts' => 'plus:1', 
                                            'last_post' => $now, 
                                            'last_title' => $post_title, 
                                            'last_id' => $topic_id,
                                            'last_poster_id' => $starter_id, 
                                            'last_poster_name' => $starter_name ),
                                            'id='.$forum_id
                     );

Please see the compileUpdateString function in ips_kernel/classDb.php. IPS introduced the logical operators minus: and plus: within update queries with IP.Board 3.

 

[Lock Down]

Try this:

                    $this->DB->update( "forums",  
                                            "posts=posts+1, 
                                            last_post=$now, 
                                            last_title='$post_title', 
                                            last_id=$topic_id,
                                            last_poster_id=$starter_id, 
                                            last_poster_name='$starter_name'" ,
                                            "id=$forum_id"
                     );

 

[immortalxx]

buddah was correct neeed to force the type

 

[Lock Down]

Bet you didn't try my way. )

 

[Buddah]

Bet you didn't try my way. )

Try this:

                    $this->DB->update( "forums",  
                                            "posts=posts+1, 
                                            last_post=$now, 
                                            last_title='$post_title', 
                                            last_id=$topic_id,
                                            last_poster_id=$starter_id, 
                                            last_poster_name='$starter_name'" ,
                                            "id=$forum_id"
                     );

update() expects an array as the second parameter.

 

[Lock Down]

Try it. I have several that work this way.

Also check this file

admin\applications\forums\modules_public\extras\vote.php

line 273 of their own system ..

			$this->DB->update( 'polls', "votes=votes+1,choices='{$this->topic['choices']}'", "pid={$this->topic['poll_id']}", false, true );

 

[Buddah]

Yes, you're correct, but look at the last parameter. By default, it's set to false. Setting it to true means that it's a preformatted 'SET'. I wouldn't manually validate the fields if I don't have to.

 

[Lock Down]

That is your prerogative but don't make statements as fact when you don't know what you are talking about. Do some research first.

 

[Buddah]

Do research first? You said it would work when it wouldn't... You simply pasted a dysfunctional code. Don't be upset that I corrected you, dude.

 

[Lock Down]

My code was correct and I am not upset a some little boy who got spanked by his mommy.
)

You were wrong "update() expects an array as the second parameter." is absolutely wrong.=):'(

Bet you really are a star in the tenth grade.

 

[Buddah]

It does expect an array as a parameter unless you set the last parameter as true, which you do not...

Jesus dude. Let go.